fix(cli): exit findUp methods if parent dir equals current dir
#28801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byCedric
changed the title
findFileInParents if parent dir equals current dirfindUp methods if parent dir equals current dir
expo-bot
added
bot: passed checks
byCedric
deleted the
cedric/eng-12313-npx-expo-lint-gives-a-maximum-call-stack-size-exceeded
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #28799
How
Determining if the current
cwdis the root of a drive was hardcoded, and not correct for Windows. On windows, the root is something likeC:\orD:\, which also cannot be hardcoded.Instead, it now relies on
path.dirname(cwd), if that equals the currentcwdit stops. It basically means that we can't go one up anymore.Test Plan
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).