-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK 46] Can't build Android app on AppCenter if Hermes is enabled #18412
Comments
hi there! could you check whether the |
Hi @Kudo thank you for your reply. it it a monorepo, I don't know if it's important to say it |
Here the AppCenter answer: Hi There, Thanks for writing to us!
Is there any env variable need to set for HERMES_LIB to run your build? |
@TomCorvus sorry i don't familiar with AppCenter build process. does the problem happen locally by running, e.g. |
@Kudo Yes, everything works fine in my local machine. in dev or prod mode. |
that's strange. i've tried to use AppCenter with hermes and it works for me. we would need a reproducible example repo for further investigation. or maybe it's worth for you to try EAS Build |
Hi there! It looks like your issue requires a minimal reproducible example, but it is invalid or absent. Please prepare such an example and share it in a new issue. The best way to get attention to your issue is to provide a clean and easy way for a developer to reproduce the issue on their own machine. Please do not provide your entire project, or a project with more code than is necessary to reproduce the issue. A side benefit of going through the process of narrowing down the minimal amount of code needed to reproduce the issue is that you may get lucky and discover that the bug is due to a mistake in your application code that you can quickly fix on your own. ResourcesCommon concerns"I've only been able to reproduce it in private, proprietary code"You may not have spent enough time narrowing down the root cause of the issue. Try out the techniques discussed in this manual debugging guide to learn how to isolate the problem from the rest of your codebase. "I didn't have time to create one"That's understandable, it can take some time to prepare. We ask that you hold off on filing an issue until you are able to fully complete the required fields in the issue template. "You can reproduce it by yourself by creating a project and following these steps"This is useful knowledge, but it's still valuable to have the resulting project that is produced from running the steps, where you have verified you can reproduce the issue. |
Did this get fixed? If so, what was the solution? |
I gave more information on this issue #18473 |
The prepareHermes() task was missing a declaration for file dependencies, so builds that were run alongside a clean command failed, for example in AppCenter which runs `clean app:assembleRelease app:bundleRelease` as one command. Fixes expo#18473 and expo#18412
The prepareHermes() task was missing a declaration for file dependencies, so builds that were run alongside a clean command failed, for example in AppCenter which runs `clean app:assembleRelease app:bundleRelease` as one command. Fixes expo#18473 and expo#18412
For temporary use, you can use this patch pacakge
|
@Kudo I'm getting these warnings as well:
|
@KrisLau what's your expo version? |
@TomCorvus
It shouldn't matter that the versions are incompatible with expo right since I'm running them with a bare react native project? Sorry if this is a dumb question I only recently migrated from unimodules so i'm not sure |
@KrisLau I am also getting the same error. were you able to fix this? |
@alperenkarip I can't remember what I did that fixed it but make sure to look at the setup documentation for expo modules in addition to the migration document because the migration is missing a bunch of steps |
same error, can anyone help us? |
I'm facing a similar error
My version :
App works fine during local build and debugging with metrobundler, but when creating signed apk it shows error |
Still having this issue
|
Hi, I麓m having similar issue
|
Not sure if this is related to anyone's problem here but just in case: |
Hi @KrisLau , You're right sorry. |
Hay, where you able to fix this and how please. Your issue is the same with mine. Thanks |
have someone fixed the issue? |
Summary
Hi 馃憢
I can't build Android app on AppCenter since SDK 46 if Hermes is enabled.
If I disable Hermes, it's working on AppCenter.
If I try to generate binary with Android Studio on my computer, it's working too (with Hermes or without)
I will send a message to AppCenter team, maybe it miss something on build environment.
Thanks for your help.
I have this error message:
Managed or bare workflow? If you have
ios/
orandroid/
directories in your project, the answer is bare!bare
What platform(s) does this occur on?
Android
SDK Version (managed workflow only)
No response
Environment
Reproducible demo
Init a bare expo app, enable Hermes and try to build it with AppCenter.
Sorry to not give repro, but the problem appears on AppCenter with minimal project setup.
The text was updated successfully, but these errors were encountered: