From 60eefc049746be1e4aff27f2524c58b72e683464 Mon Sep 17 00:00:00 2001 From: Evan Bacon Date: Fri, 4 Nov 2022 16:02:39 -0500 Subject: [PATCH] fix(cli): improve ngrok error message format (#19822) * fix(cli): improve ngrok error message format * Update packages/@expo/cli/CHANGELOG.md Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com> * Update packages/@expo/cli/src/start/server/AsyncNgrok.ts Co-authored-by: Brent Vatne Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com> Co-authored-by: Brent Vatne --- packages/@expo/cli/CHANGELOG.md | 2 ++ packages/@expo/cli/src/start/server/AsyncNgrok.ts | 8 ++++---- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/packages/@expo/cli/CHANGELOG.md b/packages/@expo/cli/CHANGELOG.md index 28ebfb04f9b58..9ed2fcc893afb 100644 --- a/packages/@expo/cli/CHANGELOG.md +++ b/packages/@expo/cli/CHANGELOG.md @@ -12,6 +12,8 @@ ### 💡 Others +- Fix ngrok error message format. ([#19822](https://github.com/expo/expo/pull/19822) by [@EvanBacon](https://github.com/EvanBacon)) + ## 0.4.6 — 2022-11-02 ### 🎉 New features diff --git a/packages/@expo/cli/src/start/server/AsyncNgrok.ts b/packages/@expo/cli/src/start/server/AsyncNgrok.ts index d5a0776587061..723386597a526 100644 --- a/packages/@expo/cli/src/start/server/AsyncNgrok.ts +++ b/packages/@expo/cli/src/start/server/AsyncNgrok.ts @@ -1,3 +1,4 @@ +import chalk from 'chalk'; import crypto from 'crypto'; import * as path from 'path'; import slugify from 'slugify'; @@ -165,10 +166,9 @@ export class AsyncNgrok { onStatusChange(status) { if (status === 'closed') { Log.error( - 'We noticed your tunnel is having issues. ' + - 'This may be due to intermittent problems with ngrok. ' + - 'If you have trouble connecting to your app, try to restart the project, ' + - 'or switch the host to `lan`.' + chalk.red( + 'Tunnel connection has been closed. This is often related to intermittent connection problems with the Ngrok servers. Restart the dev server to try connecting to Ngrok again.' + ) ); } else if (status === 'connected') { Log.log('Tunnel connected.');