Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @action/core to remove deprecation warning of set-output command #194

Closed
lacasseio opened this issue Nov 21, 2022 · 1 comment
Closed

Comments

@lacasseio
Copy link

Description of the bug

GitHub announced that set-output command is now deprecated. This deprecation spam any CI build using Expo GitHub Actions with a deprecation message.

To Reproduce

Use expo/expo-github-action@v7 and/or expo/expo-github-action/preview-comment@v7 in a GitHub workflow.

Expected behavior

There should be no deprecation warning appearing when using Expo actions.

Actual behavior

What did it actually result in?
We see deprecation warnings appearing when using Expo actions:
Screen Shot 2022-11-21 at 8 43 38 PM

Additional context

It seems Expo GitHub Actions doesn't directly use set-output command but uses setOutput from @action/core library, which uses the deprecated set-output command. Luckily, the issue was fixed (without API breakage) in version 1.10.0. Upgrading to that version should solve the issue. If the action is rebuilt, the package.json is correctly set up to pick the latest minor version. However, it would be safe to upgrade to 1.10.0 to make sure.

@byCedric
Copy link
Member

byCedric commented Jan 4, 2023

Fixed by #202 - published in v7.2.1

@byCedric byCedric closed this as completed Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants