Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

Update Android uninstalling copy #2763

Merged
merged 2 commits into from Oct 8, 2020

Conversation

brooksbecton
Copy link
Contributor

Fixes #2756

@brentvatne
Copy link
Member

thanks! we should also update the installing copy:

Installing Expo on device

@brooksbecton
Copy link
Contributor Author

May have found two more instances

One says, "Opens your app in Expo on a connected Android device"
Wasn't sure if these should say something like "Opens your app the Expo client on a connected Android device"

.option('-a, --android', 'Opens your app in Expo on a connected Android device')

'Opens your app in Expo in a currently running iOS simulator on your computer'

@brentvatne brentvatne merged commit 385603f into expo:master Oct 8, 2020
@brentvatne
Copy link
Member

One says, "Opens your app in Expo on a connected Android device"
Wasn't sure if these should say something like "Opens your app the Expo client on a connected Android device"

i think the latter is indeed better wording! follow-up pr welcome! thanks for the help

@brooksbecton brooksbecton deleted the Update-Uninstalling-Copy branch October 8, 2020 12:34
@brooksbecton
Copy link
Contributor Author

Would you mind adding a hacktoberfest-accepted label to this PR?
If not, I understand.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use "Expo client" instead of "Expo"
2 participants