[expo-cli] Fix parallel uploads

[LinusU]

This fixes the issue I commented about here: https://github.com/expo/expo-cli/pull/2504/files#r497315193

[...] with this change, only one single process can upload one build artefact at a time, since otherwise the file will be deleted from under that process. E.g. trying to run expo upload:ios and expo upload:android in parallel will have one of them fail with either:

Error setting value '/tmp/expo-submission-service/foo-xxxxxx-signed.aab' for option 'aab'
Could not find aab file at path '/tmp/expo-submission-service/foo-xxxxxx-signed.aab'

or:

Failed to upload the standalone app to the app store.
Could not find file at path '/tmp/expo-submission-service/foo-xxxxxx-archive.ipa'

We have build scripts that submits several builds at the same time, and this is currently breaking our workflow. Would it be possible to use a new folder each time, instead of always using expo-submission-service?

I'll send a pull request with that change, but I'm also happy to consider any other approach to solve this 👍

Before this patch, the path /tmp/expo-submission-service was always used for every process, and was always nuked when that upload process started. With this patch, this have been changed to be a temporary directory. That way different processes will not interfere with each other.

(ping @EvanBacon)

[LinusU]

If any one needs this fix asap, or want to try it out locally, you can run the following command to patch the built file in place:

curl https://locousercontent.com/JItaW1jtwirlcxfW057ehxd6gcnYILYQQggKY7DKqOJbrw7vmSexUJHj2WnrfzOX/original.js > node_modules/expo-cli/build/commands/upload/submission-service/utils/files.js

[EvanBacon]

Seems fine, tests are failing though. Have you run this locally to ensure it works?

[LinusU]

I've have tried it locally, and managed to upload ~50 apps with 5 parallel workers, so I'm quite sure that it works 😅

Hmm, interesting:

   TypeError: _tempy(...).default.directory is not a function

      96 |   // Since we may need to rename the destination path,
      97 |   // add everything to a folder which can be nuked to ensure we don't accidentally use an old build with the same name.
   >  98 |   const destinationFolder = temporary.directory();
         |                                       ^
      99 |   const destinationPath = join(destinationFolder, filename);
     100 | 
     101 |   // Special use-case for downloading an EAS tar.gz file and unpackaging it.

I'm importing and using it in the same way that other parts of the code is:

Maybe it's something with mocking during the tests 🤔

[LinusU]

@EvanBacon managed to fix it, just needed to mock out temp-dir to work with memfs: 982265b