Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ultrajson #61

Closed
AsymptoticBrain opened this issue Apr 8, 2022 · 3 comments · Fixed by #62
Closed

Update Ultrajson #61

AsymptoticBrain opened this issue Apr 8, 2022 · 3 comments · Fixed by #62

Comments

@AsymptoticBrain
Copy link

Hi,

Ultrajson recently got updated, I'm uncertain how it works with forks and srsly being standalone but is it possible to update the version used in srsly to use this latest version?

//Tim

@svlandeg
Copy link
Member

svlandeg commented Apr 8, 2022

Thanks for the note, we'll definitely have a look!

@adrianeboyd
Copy link
Collaborator

So far we've just ported changes as needed. Aside from the security vulnerability, are there any other updates that are relevant to you? Since it's not in the standard, my initial preference would be to leave out the NaN and Infinity changes. We have had users running into issues accidentally trying to serialize NaN, but usually it's because of another bug, not something that our users need to do with srsly in general.

@AsymptoticBrain
Copy link
Author

No, it was mainly the security issue that was flagged and I wanted to get rid off.

@adrianeboyd adrianeboyd linked a pull request Apr 8, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants