Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix meta serialization in train #5751

Merged
merged 1 commit into from
Jul 12, 2020
Merged

fix meta serialization in train #5751

merged 1 commit into from
Jul 12, 2020

Conversation

DeNeutoy
Copy link
Contributor

Description

The meta serialized in the final model in cli/train.py is actually the model's meta, not the meta provided via the commandline. This overwrites the meta in the final-model directory before reading it in again, so it is up to date.

Types of change

bug fix

Checklist

  • [x ] I have submitted the spaCy Contributor Agreement.
  • I ran the tests, and all new and existing tests passed.
  • [ x] My changes don't require a change to the documentation, or if they do, I've added all required information.

@honnibal honnibal merged commit 27a1cd3 into explosion:master Jul 12, 2020
@svlandeg svlandeg added bug Bugs and behaviour differing from documentation feat / serialize Feature: Serialization, saving and loading training Training and updating models feat / cli Feature: Command-line interface labels Jul 13, 2020
@adrianeboyd adrianeboyd mentioned this pull request Sep 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Bugs and behaviour differing from documentation feat / cli Feature: Command-line interface feat / serialize Feature: Serialization, saving and loading training Training and updating models
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DeNeutoy @honnibal @svlandeg