Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lemmatizer is_base_form for python2.7 #5734

Merged
merged 3 commits into from
Jul 9, 2020
Merged

Fix lemmatizer is_base_form for python2.7 #5734

merged 3 commits into from
Jul 9, 2020

Conversation

adrianeboyd
Copy link
Contributor

@adrianeboyd adrianeboyd commented Jul 9, 2020 •
edited

Description

Fix lemmatizer is_base_form for python2.7

Fixes #5729.

Types of change

Bug fix.

Checklist

  • I have submitted the spaCy Contributor Agreement.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@adrianeboyd adrianeboyd added bug Bugs and behaviour differing from documentation compat Cross-platform and cross-Python compatibility feat / lemmatizer Feature: Rule-based and lookup lemmatization labels Jul 9, 2020
@adrianeboyd
Copy link
Contributor Author

The only remaining python2 issue here is that you can't pickle a PhraseMatcher due to this method.

@adrianeboyd adrianeboyd changed the title Fix lemmatizer init args for python2.7 Fix lemmatizer is_base_form for python2.7 Jul 9, 2020
@honnibal honnibal merged commit 0a62098 into explosion:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Bugs and behaviour differing from documentation compat Cross-platform and cross-Python compatibility feat / lemmatizer Feature: Rule-based and lookup lemmatization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spaCy v2.3.1 can't be imported in Python 2.7
2 participants
@adrianeboyd @honnibal