Skip to content

Fixed vocabulary in the entity linker training example #5676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 3, 2020
Merged

Fixed vocabulary in the entity linker training example #5676

merged 3 commits into from
Jul 3, 2020
+3 −3

Conversation

hertelm
Copy link
Contributor

@hertelm hertelm commented Jun 30, 2020

Description

Fixes #5668 for the entity linker training example, according to the first comment by @adrianeboyd .

Types of change

documentation

Checklist

  • I have submitted the spaCy Contributor Agreement.
  • I ran the tests, and all new and existing tests passed. --> I tested the modified example code.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

Sorry, something went wrong.

hertelm added 3 commits June 30, 2020 11:41
@hertelm
entity linker training example: model loading changed according to is…
6043c33 
…sue 5668 (explosion#5668) + vocab_path is a required argument
@hertelm
contributor agreement
534acf7
@hertelm
Merge branch 'master' into fixed_entity_linker_training_example

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
3e212bd
@adrianeboyd adrianeboyd requested a review from svlandeg July 2, 2020 16:19
@svlandeg svlandeg added enhancement Feature requests and improvements examples Code examples in /examples feat / nel Feature: Named Entity linking labels Jul 3, 2020
svlandeg
svlandeg approved these changes Jul 3, 2020
View reviewed changes
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for the contribution! Highly appreciated :-)

@svlandeg svlandeg merged commit 2fb9bd7 into explosion:master Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svlandeg svlandeg

Assignees
No one assigned
Labels
enhancement Feature requests and improvements examples Code examples in /examples feat / nel Feature: Named Entity linking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hertelm @svlandeg