Avoid ConcurrentModificationException at shutdown #3113
Merged
+82
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tdown issues with exist-xqts-runner
joewiz
approved these changes
Nov 15, 2019
There was a problem hiding this comment.
Before this PR, the exist-xqts-runner would die after 1,638 tests, with the following error:
08 Nov 2019 10:02:19,058 [XQTSRunnerSystem-akka.actor.default-dispatcher-22] INFO (slf4j.scala [info]:159) - Serialized results for TestSet: fn-distinct-values OK.
Exception in thread "global.BrokerPools.ShutdownHook" java.util.ConcurrentModificationException
at java.util.HashMap$HashIterator.nextNode(HashMap.java:1445)
at java.util.HashMap$KeyIterator.next(HashMap.java:1469)
at org.exist.storage.ProcessMonitor.killAll(ProcessMonitor.java:305)
at org.exist.storage.BrokerPool.shutdown(BrokerPool.java:1610)
at org.exist.storage.BrokerPools.stopAll(BrokerPools.java:281)
at org.exist.storage.BrokerPools.lambda$0(BrokerPools.java:69)
at java.lang.Thread.run(Thread.java:748)
After rebuilding with this PR, exist-xqts-runner completed 8,306 tests, so evidently this PR has helped!
dizzzz
approved these changes
Nov 15, 2019
adamretter
deleted the
hotfix/ProcessMonitor-ConcurrentModificationException
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were missing some synchronisation. This was shown by the test suite https://github.com/eXist-db/exist-xqts-runner