Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fruit Picker: hints are outdated #1833

Open
SleeplessByte opened this issue Jul 10, 2022 · 8 comments
Open

Fruit Picker: hints are outdated #1833

SleeplessByte opened this issue Jul 10, 2022 · 8 comments
Assignees
Labels
bug 🐛 Something isn't working x:action/fix Fix an issue x:knowledge/none No existing Exercism knowledge required x:module/concept-exercise Work on Concept Exercises x:size/small Small amount of work x:status/claimed Someone is working on this issue x:type/content Work on content (e.g. exercises, concepts)

Comments

@SleeplessByte
Copy link
Member

SleeplessByte commented Jul 10, 2022

Related but not covered by #1818,

The hints have not been updated in #1725. For example, the first task:

- Use the imported API function checkStatus in your function.
- Pass a callback function to checkStatus. It should expect to receive a string argument.
- Return the result from the checkStatus API function.

But the correct implementation is:

export function onSuccess() {
  notify({ message: 'SUCCESS' })
}

The hints.md file can be found here: https://github.com/exercism/javascript/blob/main/exercises/concept/fruit-picker/.docs/hints.md

General information of how to write the hints.md file can be found here: https://exercism.org/docs/building/tracks/concept-exercises#h-file-docs-hints-md

@junedev junedev added bug 🐛 Something isn't working help wanted x:action/fix Fix an issue x:knowledge/none No existing Exercism knowledge required x:module/concept-exercise Work on Concept Exercises x:type/content Work on content (e.g. exercises, concepts) x:size/small Small amount of work labels Jul 12, 2022
@junedev
Copy link
Member

junedev commented Jul 12, 2022

cc @neenjaw in case you have time for this

@dunndeft
Copy link

Hello. How can I assist in updating the hints? This is my first attempt at contributing to Exercism.

@dunndeft
Copy link

@junedev, please see the paragraph text under "This task requires you to fix something broken"... it says "...you'll be bulding taking something that's currently not working...". The word bulding can be changed to building. It's spelled this way in the other pop-up instructions too.

image

@junedev
Copy link
Member

junedev commented Jul 13, 2022

@dunndeft Good catch regarding the typo. Could you please create an issue for this here: https://github.com/exercism/exercism. The people that monitor those issues are able to fix the typo. The main website repository does not accept contributions.

@DANTELX
Copy link

DANTELX commented Jul 23, 2022

Hi, is there any way I could help with this issue? I'm trying to make my first contribution on GitHub :)

@junedev
Copy link
Member

junedev commented Aug 5, 2022

@dunndeft Do you still intend to work on the hints or can @DANTELX take over this task?

@triangletrianglesquareplusx
Copy link
Contributor

Hello people, do you still need help with this?

@junedev
Copy link
Member

junedev commented Oct 25, 2022

@triangletrianglesquareplusx Yes, I will assign you to the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working x:action/fix Fix an issue x:knowledge/none No existing Exercism knowledge required x:module/concept-exercise Work on Concept Exercises x:size/small Small amount of work x:status/claimed Someone is working on this issue x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
Development

No branches or pull requests

5 participants