Added filles for the new rest and spread exericse #1989

meatball133 · 2022-11-11T18:16:51Z

Resolve #1500

This is the start for the exercise. There is still some stuff that I haven't started on like hints and design.

It is because I think they require that the rest is more or less finished.

github-actions · 2022-11-11T18:17:04Z

Dear meatball133

Thank you for contributing to the JavaScript track on Exercism! 💙
You will see some automated feedback below 🤖. It would be great if you can make sure your PR covers those points. This will save your reviewer some time and your change can be merged quicker.

📜 The following files usually contain very similar content.
- concepts/<concept>/about.md
- concepts/<concept>/introduction.md
- exercises/concept/<exercise>/.docs/introduction.md
Please check whether the changes you made to one of these also need to be applied to the others.
🧦 If you changed the function signature or the JSDoc comment in the exemplar file (.meta/exemplar.js) or the stub file (<exercise>.js), make sure the change is applied to both files.
✍️ If your PR is not related to an existing issue (and is not self-explaining like a typo fix), please make sure the description explains why the change you made is necessary.
🔤 If your PR fixes an easy to identify typo, if would be great if you could check for that typo in the whole repo. For example, if you found Unicdoe, use "replace all" in your editor (or command line magic) to fix it consistently.

Dear Reviewer/Maintainer

📏 Make sure you set the appropriate x:size label for the PR. (This also works after merging, in case you forgot about it.)
🔍 Don't be too nit-picky. If the PR is a clear improvement compared to the status quo, it should be approved as clear signal this is good to be merged even if the minor comments you might have are not addressed by the contributor. Further improvement ideas can be captured in issues (if important enough) and implemented via additional PRs.
🤔 After reviewing the diff in the "Files changed" section, take a moment to think about whether there are changes missing from the diff. Does something need to be adjusted in other places so the code or content stays consistent?

_{Automated comment created by PR Commenter 🤖.}

junedev

Thanks for getting started with the content. I reviewed the instructions file and left some comments.

exercises/concept/train-driver/.docs/instructions.md

junedev · 2022-11-12T07:10:25Z

exercises/concept/train-driver/.docs/instructions.md

+
+Your friend has been keeping track of how much each wagon weighs. Although they are not sure how many wagons and would like the data to be returned as an array.
+
+```exercism/note


Note blocks should not be used for the normal instructions of the exercise, only for special things that need to stand out (like the note at the top about using rest and spread).

Applies to all the tasks.

exercises/concept/train-driver/.docs/instructions.md

meatball133 · 2022-11-15T18:29:29Z

I feel like I have resolved the issues mentioned above. If not please tell me and I will give it another round

SleeplessByte · 2022-11-15T18:54:07Z

I feel like I have resolved the issues mentioned above. If not please tell me and I will give it another round

Thank you for the work!

We'll check it out.

meatball133 · 2022-11-20T13:37:06Z

Could some one go through with me why errors are raised? The changes I made should not have caused this.

SleeplessByte · 2023-01-01T21:18:40Z

Could some one go through with me why errors are raised? The changes I made should not have caused this.

Sorry I didn't see this. Seems you managed to solve this yourself!

For future contributions, on this track repository you can post a comment with / followed by format and it will format it on the PR directly.

meatball133 · 2023-01-01T21:20:03Z

I see, no problem. But thanks for the tip.

I made some commits to some other tracks, so I learnt there how the config file needs to be setup.

SleeplessByte · 2023-06-09T14:13:50Z

I see, no problem. But thanks for the tip.

I made some commits to some other tracks, so I learnt there how the config file needs to be setup.

I'll pick up the reviewing here :)

SleeplessByte · 2023-06-09T15:58:40Z

exercises/concept/train-driver/.docs/hints.md

+
+## 1. Create a list of all wagons
+
+- Multiple arguments in the function parameters can be packed with the `...<args>` operator.


Suggested change

- Multiple arguments in the function parameters can be packed with the `...<args>` operator.

- Multiple arguments in the function parameters can be packed with the [`...<args>` (spread) syntax][spread-syntax].

SleeplessByte · 2023-06-09T16:00:38Z

exercises/concept/train-driver/.docs/hints.md

+
+## 2. Move the first two elements to the end of the array
+
+- Using unpacking with the rest operator(`...`), lets you extract the first two elements of a `array` while keeping the rest intact.


Suggested change

- Using unpacking with the rest operator(`...`), lets you extract the first two elements of a `array` while keeping the rest intact.

- You can unpack a series of parameters using [a destructuring assignment (`...`)][destructuring assignment].

This lets you extract the first two elements of a `array` while keeping the rest intact.

Added filles

f98dbb8

meatball133 marked this pull request as draft November 11, 2022 18:18

fixes

77ca83d

junedev reviewed Nov 12, 2022

View reviewed changes

meatball133 added 6 commits November 12, 2022 09:48

fixes

92ecfba

further fixes and updated last exercise

d25d85e

Replace whole numbers

fb96f63

Update instructions.md

439ddd2

Various fixes and updated test file

8e6b360

fix smal typo

1a0a3fc

meatball133 force-pushed the main branch from e114db9 to 1a0a3fc Compare November 12, 2022 13:22

fix small typo

71a9dac

meatball133 added 2 commits November 15, 2022 20:21

Small typo fix

a327c00

Updated the story and added contributors

e1af39e

meatball133 and others added 11 commits November 20, 2022 15:12

fix typo

d5ae91d

fix

6d38528

Update instructions.md

94163e1

Further fixes

4e1b623

fix bug created

b86a994

Fixes and changes to instructions

d73f782

Runned prettier and aded hints

166a823

Merge branch 'exercism:main' into main

f826acd

Runed babel

47f0ffe

runed babel again

96c8bcb

Runned prettier again

a5fef2f

meatball133 marked this pull request as ready for review December 29, 2022 12:07

meatball133 requested a review from junedev January 14, 2023 23:22

SleeplessByte self-requested a review June 9, 2023 14:13

SleeplessByte reviewed Sep 8, 2023

View reviewed changes

meatball133 added 3 commits September 22, 2023 21:41

Add links

c45f0ff

Merge branch 'exercism:main' into main

9f35761

Sync and format

c48bd27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added filles for the new rest and spread exericse #1989

Added filles for the new rest and spread exericse #1989

meatball133 commented Nov 11, 2022

github-actions bot commented Nov 11, 2022

junedev left a comment

junedev Nov 12, 2022

meatball133 commented Nov 15, 2022

SleeplessByte commented Nov 15, 2022

meatball133 commented Nov 20, 2022 •

edited

SleeplessByte commented Jan 1, 2023

meatball133 commented Jan 1, 2023 •

edited

SleeplessByte commented Jun 9, 2023

SleeplessByte Jun 9, 2023

SleeplessByte Jun 9, 2023


		Your friend has been keeping track of how much each wagon weighs. Although they are not sure how many wagons and would like the data to be returned as an array.

		```exercism/note


		## 1. Create a list of all wagons

		- Multiple arguments in the function parameters can be packed with the `...<args>` operator.


		## 2. Move the first two elements to the end of the array

		- Using unpacking with the rest operator(`...`), lets you extract the first two elements of a `array` while keeping the rest intact.

	- Using unpacking with the rest operator(`...`), lets you extract the first two elements of a `array` while keeping the rest intact.
	- You can unpack a series of parameters using [a destructuring assignment (`...`)][destructuring assignment].
	This lets you extract the first two elements of a `array` while keeping the rest intact.

Added filles for the new rest and spread exericse #1989

Are you sure you want to change the base?

Added filles for the new rest and spread exericse #1989

Conversation

meatball133 commented Nov 11, 2022

github-actions bot commented Nov 11, 2022

Dear meatball133

Dear Reviewer/Maintainer

junedev left a comment

Choose a reason for hiding this comment

junedev Nov 12, 2022

Choose a reason for hiding this comment

meatball133 commented Nov 15, 2022

SleeplessByte commented Nov 15, 2022

meatball133 commented Nov 20, 2022 • edited

SleeplessByte commented Jan 1, 2023

meatball133 commented Jan 1, 2023 • edited

SleeplessByte commented Jun 9, 2023

SleeplessByte Jun 9, 2023

Choose a reason for hiding this comment

SleeplessByte Jun 9, 2023

Choose a reason for hiding this comment

meatball133 commented Nov 20, 2022 •

edited

meatball133 commented Jan 1, 2023 •

edited