From 3df791c0193146bd5dd9d6de0e9b81cda9e5f095 Mon Sep 17 00:00:00 2001 From: Pedre Viljoen Date: Tue, 12 Apr 2022 21:35:48 +0200 Subject: [PATCH 1/6] chore: bumped go to version 1.18 --- .github/workflows/test.yml | 6 +++--- .gitignore | 1 + Dockerfile | 2 +- go.mod | 2 +- testrunner/testdata/concept/conditionals/go.mod | 2 +- testrunner/testdata/practice/broken/go.mod | 2 +- testrunner/testdata/practice/broken_import/go.mod | 2 +- testrunner/testdata/practice/failing/go.mod | 2 +- testrunner/testdata/practice/gigasecond/go.mod | 2 +- testrunner/testdata/practice/missing_func/go.mod | 2 +- testrunner/testdata/practice/passing/go.mod | 2 +- testrunner/testdata/practice/pkg_level_error/go.mod | 2 +- testrunner/testdata/practice/runtime_error/go.mod | 2 +- 13 files changed, 15 insertions(+), 14 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 18a57e7..1e58c3a 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -10,7 +10,7 @@ jobs: - name: Install Go uses: actions/setup-go@v2 with: - go-version: 1.17.x + go-version: 1.18.x - name: Checkout code uses: actions/checkout@v2 - name: Run linters @@ -21,7 +21,7 @@ jobs: test: strategy: matrix: - go-version: [1.17.x] + go-version: [1.18.x] # platform: [ubuntu-latest, macos-latest, windows-latest] platform: [ubuntu-latest] runs-on: ${{ matrix.platform }} @@ -43,7 +43,7 @@ jobs: if: success() uses: actions/setup-go@v2 with: - go-version: 1.17.x + go-version: 1.18.x - name: Checkout code uses: actions/checkout@v2 - name: Calc coverage diff --git a/.gitignore b/.gitignore index 4143939..786938b 100644 --- a/.gitignore +++ b/.gitignore @@ -4,6 +4,7 @@ bin/* log/* .ipynb_checkpoints/ +.idea # Test binary, build with `go test -c` *.test diff --git a/Dockerfile b/Dockerfile index 5a4dba5..15a9e36 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,4 +1,4 @@ -FROM golang:1.17-alpine3.14 +FROM golang:1.18-alpine3.15 # add addtional packages needed for the race detector to work RUN apk add --update build-base make diff --git a/go.mod b/go.mod index 88e2ae7..7f0089f 100644 --- a/go.mod +++ b/go.mod @@ -1,3 +1,3 @@ module github.com/exercism/go-test-runner -go 1.17 +go 1.18 diff --git a/testrunner/testdata/concept/conditionals/go.mod b/testrunner/testdata/concept/conditionals/go.mod index c5868d0..ceac322 100644 --- a/testrunner/testdata/concept/conditionals/go.mod +++ b/testrunner/testdata/concept/conditionals/go.mod @@ -1,3 +1,3 @@ module conditionals -go 1.17 +go 1.18 diff --git a/testrunner/testdata/practice/broken/go.mod b/testrunner/testdata/practice/broken/go.mod index f7b380f..989fd97 100644 --- a/testrunner/testdata/practice/broken/go.mod +++ b/testrunner/testdata/practice/broken/go.mod @@ -1,3 +1,3 @@ module gigasecond -go 1.17 +go 1.18 diff --git a/testrunner/testdata/practice/broken_import/go.mod b/testrunner/testdata/practice/broken_import/go.mod index f7b380f..989fd97 100644 --- a/testrunner/testdata/practice/broken_import/go.mod +++ b/testrunner/testdata/practice/broken_import/go.mod @@ -1,3 +1,3 @@ module gigasecond -go 1.17 +go 1.18 diff --git a/testrunner/testdata/practice/failing/go.mod b/testrunner/testdata/practice/failing/go.mod index f7b380f..989fd97 100644 --- a/testrunner/testdata/practice/failing/go.mod +++ b/testrunner/testdata/practice/failing/go.mod @@ -1,3 +1,3 @@ module gigasecond -go 1.17 +go 1.18 diff --git a/testrunner/testdata/practice/gigasecond/go.mod b/testrunner/testdata/practice/gigasecond/go.mod index f7b380f..989fd97 100644 --- a/testrunner/testdata/practice/gigasecond/go.mod +++ b/testrunner/testdata/practice/gigasecond/go.mod @@ -1,3 +1,3 @@ module gigasecond -go 1.17 +go 1.18 diff --git a/testrunner/testdata/practice/missing_func/go.mod b/testrunner/testdata/practice/missing_func/go.mod index f7b380f..989fd97 100644 --- a/testrunner/testdata/practice/missing_func/go.mod +++ b/testrunner/testdata/practice/missing_func/go.mod @@ -1,3 +1,3 @@ module gigasecond -go 1.17 +go 1.18 diff --git a/testrunner/testdata/practice/passing/go.mod b/testrunner/testdata/practice/passing/go.mod index f7b380f..989fd97 100644 --- a/testrunner/testdata/practice/passing/go.mod +++ b/testrunner/testdata/practice/passing/go.mod @@ -1,3 +1,3 @@ module gigasecond -go 1.17 +go 1.18 diff --git a/testrunner/testdata/practice/pkg_level_error/go.mod b/testrunner/testdata/practice/pkg_level_error/go.mod index 8a0f257..f9c1a81 100644 --- a/testrunner/testdata/practice/pkg_level_error/go.mod +++ b/testrunner/testdata/practice/pkg_level_error/go.mod @@ -1,4 +1,4 @@ module pov -go 1.17 +go 1.18 diff --git a/testrunner/testdata/practice/runtime_error/go.mod b/testrunner/testdata/practice/runtime_error/go.mod index f7b380f..989fd97 100644 --- a/testrunner/testdata/practice/runtime_error/go.mod +++ b/testrunner/testdata/practice/runtime_error/go.mod @@ -1,3 +1,3 @@ module gigasecond -go 1.17 +go 1.18 From ba7e62407b751258e5e47cbb330f082470cec037 Mon Sep 17 00:00:00 2001 From: pedreviljoen Date: Wed, 13 Apr 2022 08:59:16 +0200 Subject: [PATCH 2/6] chore: PR comments for global gitignore --- .gitignore | 1 - 1 file changed, 1 deletion(-) diff --git a/.gitignore b/.gitignore index 786938b..4143939 100644 --- a/.gitignore +++ b/.gitignore @@ -4,7 +4,6 @@ bin/* log/* .ipynb_checkpoints/ -.idea # Test binary, build with `go test -c` *.test From 1c74e96dd8a476704b1cac5802765f14aeb25675 Mon Sep 17 00:00:00 2001 From: pedreviljoen Date: Thu, 12 May 2022 14:22:26 +0200 Subject: [PATCH 3/6] added: updated golang lint action version --- .github/workflows/test.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 1e58c3a..0153b29 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -8,15 +8,15 @@ jobs: runs-on: ubuntu-latest steps: - name: Install Go - uses: actions/setup-go@v2 + uses: actions/setup-go@v3 with: go-version: 1.18.x - name: Checkout code uses: actions/checkout@v2 - name: Run linters - uses: golangci/golangci-lint-action@v2 + uses: golangci/golangci-lint-action@v3 with: - version: v1.43 + version: v1.46 test: strategy: From 9d771dd054911ac5b0a325784b313f2f49554cf5 Mon Sep 17 00:00:00 2001 From: pedreviljoen Date: Thu, 26 May 2022 09:18:40 +0200 Subject: [PATCH 4/6] added: bump action version for setup-go & checkout --- .github/workflows/test.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 0153b29..a4a4952 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -12,7 +12,7 @@ jobs: with: go-version: 1.18.x - name: Checkout code - uses: actions/checkout@v2 + uses: actions/checkout@v3 - name: Run linters uses: golangci/golangci-lint-action@v3 with: @@ -28,11 +28,11 @@ jobs: steps: - name: Install Go if: success() - uses: actions/setup-go@v2 + uses: actions/setup-go@v3 with: go-version: ${{ matrix.go-version }} - name: Checkout code - uses: actions/checkout@v2 + uses: actions/checkout@v3 - name: Run tests run: go test ./... -v -covermode=count @@ -41,11 +41,11 @@ jobs: steps: - name: Install Go if: success() - uses: actions/setup-go@v2 + uses: actions/setup-go@v3 with: go-version: 1.18.x - name: Checkout code - uses: actions/checkout@v2 + uses: actions/checkout@v3 - name: Calc coverage run: | go test ./... -v -covermode=count -coverprofile=coverage.out From bf215051d501bd20c03ade72df005373d613f05a Mon Sep 17 00:00:00 2001 From: pedreviljoen Date: Mon, 30 May 2022 20:46:56 +0200 Subject: [PATCH 5/6] fix: code coverage failing unit tests --- .github/workflows/test.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index a4a4952..c5bc6d6 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -50,9 +50,9 @@ jobs: run: | go test ./... -v -covermode=count -coverprofile=coverage.out - name: Convert coverage.out to coverage.lcov - uses: jandelgado/gcov2lcov-action@v1.0.6 + uses: jandelgado/gcov2lcov-action@v1.0.9 - name: Coveralls - uses: coverallsapp/github-action@v1.1.2 + uses: coverallsapp/github-action@v1.1.3 with: github-token: ${{ secrets.github_token }} path-to-lcov: coverage.lcov From c93c2671c3b810588a201a6b2726a7731fa7433f Mon Sep 17 00:00:00 2001 From: pedreviljoen Date: Tue, 31 May 2022 08:41:52 +0200 Subject: [PATCH 6/6] fix: code coverage failing unit tests --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index c5bc6d6..889c32a 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -52,7 +52,7 @@ jobs: - name: Convert coverage.out to coverage.lcov uses: jandelgado/gcov2lcov-action@v1.0.9 - name: Coveralls - uses: coverallsapp/github-action@v1.1.3 + uses: coverallsapp/github-action@1.1.3 with: github-token: ${{ secrets.github_token }} path-to-lcov: coverage.lcov