Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions for Remote Control Cleanup Exercise #1951

Open
haemmer-dave opened this issue Jun 6, 2022 · 4 comments
Open

Suggestions for Remote Control Cleanup Exercise #1951

haemmer-dave opened this issue Jun 6, 2022 · 4 comments

Comments

@haemmer-dave
Copy link
Contributor

Hi,

a few suggestions for improvment. First, the theory part is very short and lacks details/examples about nested classes accessing containing classes and vice versa. It makes it look like the solution is to create a nested "Telemetry" class. However, looking at the tests, "Telemetry" is used as a property. Simply creating a nested Telemetry class will lead to compiler error CS0572. For C# beginners this is extremely confusing.

Second, the wording of task 2 and its hint are confusing as well. How an Interface, instead of a simple access modifier, is the solution is neither handled in the theory part nor understandable to me using C# docs.

@ErikSchierboom
Copy link
Member

Hi! Would you be willing to submit/work on a PR to improve this exercise?

@haemmer-dave
Copy link
Contributor Author

Yea, I can submit something to improve the theory and task 1.

However, I don't feel confident in improving task 2: I don't see the connection between the, imho, actual solution -- which is simply using an access modifier -- and the Interface hint. Maybe I'm missing something but I'm confused about task 2, hence do not really know what the original author intended and how exactly it can be improved.

@ErikSchierboom
Copy link
Member

I also feel that task 2 is quite weird. Not sure how we originally envisioned that working.

@JeanAr7
Copy link

JeanAr7 commented May 14, 2024

Hi it's 2024, the confusion still exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants