Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dark theme selectors #147

Merged
merged 1 commit into from Feb 17, 2022
Merged

Conversation

Helveg
Copy link
Contributor

@Helveg Helveg commented Feb 16, 2022

Added selectors for the data-theme selector and theme media query, so that dark theme users can avoid the sunlight a few clicks longer.

image

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #147 (7915f63) into master (e15bc85) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #147   +/-   ##
=======================================
  Coverage   92.69%   92.69%           
=======================================
  Files           2        2           
  Lines         219      219           
=======================================
  Hits          203      203           
  Misses         16       16           
Flag Coverage Δ
pytests 92.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e15bc85...7915f63. Read the comment docs.

@foster999 foster999 merged commit 16e6ee4 into executablebooks:master Feb 17, 2022
@welcome
Copy link

welcome bot commented Feb 17, 2022

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

Copy link
Contributor

@return42 return42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leave some thoughts

Comment on lines +65 to +66
font-size: 16px;
font-weight: 400;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already set in line 16-17

}

body:not([data-theme="light"]) .sphinx-tabs-tab[aria-selected="true"] {
font-weight: 700;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already set in line 25

Comment on lines +88 to +89
font-size: 16px;
font-weight: 400;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already set in line 16-17

}

body[data-theme="dark"] .sphinx-tabs-tab[aria-selected="true"] {
font-weight: 700;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already set in line 25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants