Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ UPGRADE: Bump docutils dependency to 0.17 #144

Merged
merged 1 commit into from Oct 1, 2021

Conversation

foster999
Copy link
Collaborator

Regression tests updated, as the new version now uses semantic section tags rather than the class of the same name.

Fixes #140

@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #144 (bcbfc5d) into master (ade8d9c) will increase coverage by 0.45%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
+ Coverage   92.23%   92.69%   +0.45%     
==========================================
  Files           2        2              
  Lines         219      219              
==========================================
+ Hits          202      203       +1     
+ Misses         17       16       -1     
Flag Coverage Δ
pytests 92.69% <ø> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sphinx_tabs/tabs.py 92.62% <0.00%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ade8d9c...bcbfc5d. Read the comment docs.

@foster999
Copy link
Collaborator Author

@Daltz333, any thoughts on upgrading to docutils~=0.17.0?

As there doesn't seem to include any functional changes for us, we can continue to support 0.16. Should this then be something like docutils~=0.16.0,~=0.17.0?

@Daltz333
Copy link
Collaborator

Daltz333 commented Oct 1, 2021

Since RTD theme added support for 0.17 and tests pass, it should be fine

@return42
Copy link
Contributor

return42 commented Mar 7, 2022

@foster999 could you build a release / the current release sticks at docutils v0.16 what is a show stopper in some circumstances / thanks!

@Daltz333
Copy link
Collaborator

Daltz333 commented Mar 7, 2022

I can push a release later today if he doesn't beat me to it.

@return42
Copy link
Contributor

return42 commented Mar 8, 2022

I can push a release later today if he doesn't beat me to it.

Sorry for being impatient .. just to remind / Thanks!

@foster999
Copy link
Collaborator Author

Sorry for being impatient .. just to remind / Thanks!

Thanks for nudging again - should be available at a pip near you!

@return42
Copy link
Contributor

return42 commented Mar 9, 2022

should be available at a pip near you!

Thanks a lot .. great help for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail with docutils 0.17.1 on Fedora Rawhide
3 participants