Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃И TESTS: Add testing for Python 3.9 and pygments versions #135

Merged
merged 6 commits into from Aug 20, 2021

Conversation

foster999
Copy link
Collaborator

@foster999 foster999 commented Aug 19, 2021

Adds tesing for:

@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #135 (86d7a1a) into master (0f185f4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #135   +/-   ##
=======================================
  Coverage   92.23%   92.23%           
=======================================
  Files           2        2           
  Lines         219      219           
=======================================
  Hits          202      202           
  Misses         17       17           
Flag Coverage 螖
pytests 92.23% <酶> (酶)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 0f185f4...86d7a1a. Read the comment docs.

@foster999
Copy link
Collaborator Author

Hi @humitos, I've just realised that the new test using app.set_html_assets_policy("always") wasn't getting hit because our sphinx testing version was fixed below 4.1 馃槄

I've changed that here to test the latest between 4 and 5, and the new test is now failing. It looks like the JS asset isn't being included when the config option is set. I'm stuck on why this might be, any thoughts?

@foster999 foster999 changed the title Include testing for python 3.9 馃И TESTS: Add testing for Python 3.9 and pygments versions Aug 19, 2021
@humitos
Copy link
Contributor

humitos commented Aug 20, 2021

Hi @humitos, I've just realised that the new test using app.set_html_assets_policy("always") wasn't getting hit because our sphinx testing version was fixed below 4.1 sweat_smile

I remember running the test and failing locally. Then, after some debugging, I was able to fix it (see this comment #127 (comment) where we talked about this failing test)

I'm not sure how the .html/.xml files added to this PR were generated (I didn't upload them in my original PR). So, I'm guessing there is something there that may be conflicting. I'll take a look next week.

@foster999
Copy link
Collaborator Author

Thanks, I'd totally forgotten about that. Working fine with a copy of the test source files now 馃槃

@foster999 foster999 merged commit ade8d9c into master Aug 20, 2021
@foster999 foster999 deleted the foster999-patch-1 branch August 20, 2021 11:09
@humitos
Copy link
Contributor

humitos commented Aug 20, 2021

Excellent! Happy you already fixed it! 馃挭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants