Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃И TESTS: Skip failing rinohtype tests #124

Merged
merged 2 commits into from Jun 11, 2021
Merged

Conversation

foster999
Copy link
Collaborator

I can't reproduce or identify the source of this test's failure below Python v3.8.

Skipping these tests on versions below 3.8 will allow us to release until #123 is resolved.

@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #124 (bedb905) into master (69f31ff) will decrease coverage by 4.61%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
- Coverage   97.16%   92.55%   -4.62%     
==========================================
  Files           2        2              
  Lines         212      215       +3     
==========================================
- Hits          206      199       -7     
- Misses          6       16      +10     
Flag Coverage 螖
pytests 92.55% <83.33%> (-4.62%) 猬囷笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
sphinx_tabs/tabs.py 92.48% <83.33%> (-4.66%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 5564197...bedb905. Read the comment docs.

@foster999 foster999 changed the title Skip failing rinohtype tests 馃И TESTS: Skip failing rinohtype tests Jun 11, 2021
@foster999
Copy link
Collaborator Author

@Daltz333, would you be happy for this to go in so that #117 can be released?

I'm happy to wait until this can be fixed properly, but not sure when I'll have a chance to take a deeper look

@foster999 foster999 merged commit f4d1016 into master Jun 11, 2021
@foster999 foster999 deleted the foster999-patch-1 branch June 11, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants