Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摎 DOCS: Add PDF format to the Read The Docs config #116

Merged
merged 2 commits into from May 25, 2021
Merged

馃摎 DOCS: Add PDF format to the Read The Docs config #116

merged 2 commits into from May 25, 2021

Conversation

jdillard
Copy link
Contributor

@jdillard jdillard commented May 23, 2021

That way users can preview what tabbed PDF output looks like in the official docs. This should help with questions about the current state PDF support, like in #57.

I haven't set up a RTD project yet, so I just went off the configuration docs, hopefully I got it right.

That way users can preview tabbed PDF output in the official docs.
@codecov
Copy link

codecov bot commented May 23, 2021

Codecov Report

Merging #116 (2672203) into master (45308dd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #116   +/-   ##
=======================================
  Coverage   97.16%   97.16%           
=======================================
  Files           2        2           
  Lines         212      212           
=======================================
  Hits          206      206           
  Misses          6        6           
Flag Coverage 螖
pytests 97.16% <酶> (酶)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 45308dd...2672203. Read the comment docs.

That is what I get for using the GitHub interface to make changes
@jdillard jdillard changed the title Add PDF format to the Read The Docs config 馃摎 DOCS: Add PDF format to the Read The Docs config May 23, 2021
Copy link
Collaborator

@foster999 foster999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jdillard, this looks right to me 馃憤馃徎

I considered adding ePUB and zipped HTML builds too, but we might as well wait to see if anyone would find that useful first.

@foster999 foster999 merged commit 41cdcd3 into executablebooks:master May 25, 2021
@jdillard
Copy link
Contributor Author

I thought that as well, but figured just taking a baby step might be best for now.

It's working! https://sphinx-tabs.readthedocs.io/_/downloads/en/latest/pdf/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants