Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS: require compatible docutils #800

Closed
wants to merge 1 commit into from

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Dec 20, 2023

The widespread problem with docutils 0.17 and 0.18 also affects our docs generation. As our optional docs extra is intended for internal use only, we can describe the compatibility safely in pyproject.toml rather than worrying about backsolving.

Fixes #799

@choldgraf
Copy link
Member

choldgraf commented Dec 20, 2023

Looks like we're using a deprecated function (add_javascript I believe is now add_js_file).

EDIT: Ah shoot it is in sphinx-tabs so we gotta make the fix there and make a release.

EDIT EDIT: Looks like the fix is already in there and released here: https://github.com/executablebooks/sphinx-tabs/releases/tag/v3.4.4 but for some reason this is getting downgraded in the build:

CleanShot 2023-12-20 at 11 56 49@2x

Also that website preview is pretty glorious haha

@agoose77
Copy link
Collaborator Author

The issue here is the widespread docutils div bug, and we're seeing it because sphinx-tabs doesn't yet support sphinx 7 (thus everything is downgraded). As a result, the fix is really in Sphinx-tabs (I have an open pr there)!

@choldgraf
Copy link
Member

Ah yes the docutils gift that keeps on giving

@agoose77 agoose77 closed this Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken page on the website with the documentation
2 participants