Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve styling of pull-quotes #329

Open
rowanc1 opened this issue Mar 12, 2024 · 2 comments
Open

Improve styling of pull-quotes #329

rowanc1 opened this issue Mar 12, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@rowanc1
Copy link
Member

rowanc1 commented Mar 12, 2024

From: @choldgraf here: #328 (comment)

As an example, here are several examples and inspiration for pull quotes.

Can pull quotes be placed a-la columns etc? I often see pull quotes as a sidebar with the text floating around it. For example, here's one from the NYT:

image

@rowanc1 rowanc1 added the enhancement New feature or request label Mar 12, 2024
@agoose77
Copy link
Collaborator

Is this kind of styling possible with CSS grid by default?

@rowanc1
Copy link
Member Author

rowanc1 commented Mar 20, 2024

Floats and Grids are somewhat incompatible in css, however, I think that we should have the grid system for the blocks, and some other elements, then have nested div that then we can use floats inside to do both the sidebar and margin content in a much easier way. That means top-level blocks are placed in a grid, and we can still get reflow with floats etc.

There are some things to do in that sketch of a plan though (including thinking it through more fully...) -- grids don't have margin collapse, so we have done a bunch of styling to fix the spacing inside of a grid (mb-8s in a bunch of places, etc.). There is also some logic that looks if classes internally have col- or column- and then placing a subgrid in the block for placement.

I will experiment when I look at your margin/sidebar pr tomorrow!:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants