all dataclasses in markdown_it throw errors when a different dependency tries to import it #257

DougStoker · 2023-03-24T16:14:07Z

Describe the bug

Importing a library that depends upon markdown_it leads to traceback.

Reproduce the bug

>>> import gradio as gr
Traceback (most recent call last):
  File "/Users/doug/Documents/diffusion/kohya_ss/kohya_gui.py", line 1, in <module>
    import gradio as gr
  File "/Users/doug/.pyenv/versions/3.10.0a7/lib/python3.10/site-packages/gradio/__init__.py", line 3, in <module>
    import gradio.components as components
  File "/Users/doug/.pyenv/versions/3.10.0a7/lib/python3.10/site-packages/gradio/components.py", line 28, in <module>
    from markdown_it import MarkdownIt
  File "/Users/doug/.pyenv/versions/3.10.0a7/lib/python3.10/site-packages/markdown_it/__init__.py", line 5, in <module>
    from .main import MarkdownIt
  File "/Users/doug/.pyenv/versions/3.10.0a7/lib/python3.10/site-packages/markdown_it/main.py", line 7, in <module>
    from . import helpers, presets  # noqa F401
  File "/Users/doug/.pyenv/versions/3.10.0a7/lib/python3.10/site-packages/markdown_it/helpers/__init__.py", line 5, in <module>
    from .parse_link_label import parseLinkLabel
  File "/Users/doug/.pyenv/versions/3.10.0a7/lib/python3.10/site-packages/markdown_it/helpers/parse_link_label.py", line 8, in <module>
    from markdown_it.rules_inline import StateInline
  File "/Users/doug/.pyenv/versions/3.10.0a7/lib/python3.10/site-packages/markdown_it/rules_inline/__init__.py", line 17, in <module>
    from . import emphasis, strikethrough
  File "/Users/doug/.pyenv/versions/3.10.0a7/lib/python3.10/site-packages/markdown_it/rules_inline/emphasis.py", line 4, in <module>
    from .state_inline import Delimiter, StateInline
  File "/Users/doug/.pyenv/versions/3.10.0a7/lib/python3.10/site-packages/markdown_it/rules_inline/state_inline.py", line 10, in <module>
    from ..ruler import StateBase
  File "/Users/doug/.pyenv/versions/3.10.0a7/lib/python3.10/site-packages/markdown_it/ruler.py", line 55, in <module>
    @dataclass(**DATACLASS_KWARGS)
TypeError: dataclass() got an unexpected keyword argument 'slots'

List your environment

python 3.10
macos

The text was updated successfully, but these errors were encountered:

welcome · 2023-03-24T16:14:09Z

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

agoose77 · 2023-03-24T16:42:03Z

@DougStoker I've edited your issue for legibility. I can't reproduce this. I know that dataclasses added a slots argument in 3.10. Can you ensure that you're running the following script in your environment, and list the results?

python -m pip list -vv
python --version
python -c "from markdown_it import MarkdownIt"

chrisjsewell · 2023-03-24T17:27:31Z

thanks @agoose77, I note it says the version is "3.10.0a7", perhaps it wasn't added by then, but indeed a very niche case to be using this particular Python alpha release 😅

agoose77 · 2023-03-24T17:28:17Z

Good spot, I didn't look at the venv path!

DougStoker · 2023-03-24T21:22:39Z

(base) Douglass-MacBook-Pro:~ doug$ python -m pip list -vv
Package Version Location Installer

I didn't even realize I was using an alpha version

agoose77 · 2023-03-24T21:51:39Z

@DougStoker thanks!

The short answer is that this is a bug, though it's odd that you are you using an alpha version of an older Python release. I'd suggest upgrading as the easiest solution.

The fix for this would be this PR: #258

DougStoker added the bug Something isn't working label Mar 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

all dataclasses in markdown_it throw errors when a different dependency tries to import it #257

all dataclasses in markdown_it throw errors when a different dependency tries to import it #257

DougStoker commented Mar 24, 2023 •

edited by agoose77

welcome bot commented Mar 24, 2023

agoose77 commented Mar 24, 2023 •

edited

chrisjsewell commented Mar 24, 2023

agoose77 commented Mar 24, 2023

DougStoker commented Mar 24, 2023

agoose77 commented Mar 24, 2023

all dataclasses in markdown_it throw errors when a different dependency tries to import it #257

all dataclasses in markdown_it throw errors when a different dependency tries to import it #257

Comments

DougStoker commented Mar 24, 2023 • edited by agoose77

Describe the bug

Reproduce the bug

List your environment

welcome bot commented Mar 24, 2023

agoose77 commented Mar 24, 2023 • edited

chrisjsewell commented Mar 24, 2023

agoose77 commented Mar 24, 2023

DougStoker commented Mar 24, 2023

agoose77 commented Mar 24, 2023

DougStoker commented Mar 24, 2023 •

edited by agoose77

agoose77 commented Mar 24, 2023 •

edited