Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from unmaintained pyppeteer package to alternative for building PDF documents from book #2091

Open
3 tasks
kallewesterling opened this issue Dec 13, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@kallewesterling
Copy link

Context

While exploring the option to create a download option for the whole The Turing Way as a PDF document (the-turing-way/the-turing-way#2211), we ran into an issue where the pyppeteer package runs into a Timeout Exception. It has also been documented here in the jupyter-book community, see #1732.

While there seems to be workarounds in the #1732 issue for how to resolve the Timeout Exception, I discovered that the entire pypetteer package, which jupyter-book has the docs built on, has this notice from 2021 in their README:

Attention: This repo is unmaintained and has been outside of minor changes for a long time. Please consider playwright-python as an alternative.

Proposal

This is a suggestion to change the code + instructions for how to build a PDF from a book's HTML (see the docs) to move from the now unmaintained pyppeteer package to something else (they are proposing playwright-python as an alternative).

Tasks and updates

  • Explore alternatives to pyppeteer package for download of all of a book's pages, such as playwright-python or even selenium
  • Discuss and decide which alternative to go with
  • Implement the newly selected package in the build --builder pdfhtml command's workflow
@kallewesterling kallewesterling added the enhancement New feature or request label Dec 13, 2023
Copy link

welcome bot commented Dec 13, 2023

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant