Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For v3.0.1: If the last directive option has an empty value then it is omitted #923

Closed
hroemer opened this issue Apr 25, 2024 · 5 comments · Fixed by #924
Closed

For v3.0.1: If the last directive option has an empty value then it is omitted #923

hroemer opened this issue Apr 25, 2024 · 5 comments · Fixed by #924
Labels
bug Something isn't working

Comments

@hroemer
Copy link

hroemer commented Apr 25, 2024

What version of myst-parser are you using?

3.0.0

What version dependencies are you using?

sphinx=7.3.7
docutils=0.20.1

What operating system are you using?

Linux

Describe the Bug

The glob patterns defined in a toctree directive do not work with 3.0.0 anymore.

Expected Behavior

No response

To Reproduce

```{toctree}
---
maxdepth: 2
caption: Contents
glob:
---
path*/index
pages/**
*/index
```
@hroemer hroemer added the bug Something isn't working label Apr 25, 2024
Copy link

welcome bot commented Apr 25, 2024

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

@chrisjsewell
Copy link
Member

Heya, gotta look into exactly what is going on here, but if you change the order of the option, I think it will work, e.g.

```{toctree}
---
maxdepth: 2
glob:
caption: Contents
---
path*/index
pages/**
*/index
```

let me know?

@hroemer
Copy link
Author

hroemer commented Apr 25, 2024

Yes indeed, changing the option order works 👍 .
I will have to grep through my multiple toctrees split over hundreds of files, now 😉.

@chrisjsewell
Copy link
Member

I will have to grep through my multiple toctrees split over hundreds of files, now 😉.

well, if its not urgent, then I would hope to have a fix in perhaps the next few days 😅

@chrisjsewell chrisjsewell changed the title Toctree glob patterns not working anymore with v3.0.0 If the last directive option has an empty value then it is omitted, with v3.0.0 Apr 25, 2024
@chrisjsewell chrisjsewell pinned this issue Apr 25, 2024
@chrisjsewell chrisjsewell changed the title If the last directive option has an empty value then it is omitted, with v3.0.0 For v3.0.1: If the last directive option has an empty value then it is omitted Apr 25, 2024
@hroemer
Copy link
Author

hroemer commented Apr 25, 2024

No hurry, thanks! I found a workaround by repeating the glob flag:

---
maxdepth: 2
caption: Contents
glob:
glob:
---

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants