Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔀 MERGE: Internal improvements to the code base #498

Merged
merged 5 commits into from Jan 9, 2022

Conversation

chrisjsewell
Copy link
Member

Internal improvements, that should mainly not be noticed by users

Better code documentation,
and remove some extraneous logic
Add `inline` and `allow_headings` arguments,
so that we can move some logic out of `MockState`
It makes it clearer what the attribute is,
and allows for type checking / autocompletion
@codecov
Copy link

codecov bot commented Jan 9, 2022

Codecov Report

Merging #498 (f5f0b40) into master (9039a43) will decrease coverage by 0.12%.
The diff coverage is 97.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #498      +/-   ##
==========================================
- Coverage   89.87%   89.75%   -0.13%     
==========================================
  Files          16       16              
  Lines        2075     2069       -6     
==========================================
- Hits         1865     1857       -8     
- Misses        210      212       +2     
Flag Coverage Δ
pytests 89.75% <97.50%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
myst_parser/directives.py 81.53% <90.90%> (-0.43%) ⬇️
myst_parser/docutils_renderer.py 91.58% <98.18%> (-0.15%) ⬇️
myst_parser/html_to_nodes.py 89.79% <100.00%> (ø)
myst_parser/main.py 88.80% <100.00%> (ø)
myst_parser/mocking.py 86.05% <100.00%> (-0.54%) ⬇️
myst_parser/sphinx_renderer.py 93.14% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9039a43...f5f0b40. Read the comment docs.

@chrisjsewell chrisjsewell merged commit 74e91e6 into master Jan 9, 2022
@chrisjsewell chrisjsewell deleted the nested_inline_render branch January 9, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant