myst-parser 0.12.0 fails with No module named 'markdown_it.extensions.dollarmath'

[echarles]

I open this further to jupyterlab/benchmarks#20

We have upgraded to 0.12.0 in the RDT build fails (pinning to 0.11.2 fixes the issue)

    from myst_parser.main import default_parser, MdParserConfig
  File "/home/docs/checkouts/readthedocs.org/user_builds/jupyterlab-benchmarks/envs/latest/lib/python3.7/site-packages/myst_parser/main.py", line 13, in <module>
    from markdown_it.extensions.dollarmath import dollarmath_plugin
ModuleNotFoundError: No module named 'markdown_it.extensions.dollarmath'

[chrisjsewell]

Hmm, I haven't had any issues with this 🤔 You need markdown_it_py >= 0.5, which 0.12.0 should pin:

MyST-Parser/setup.py

Line 40 in e7a2ba6

"markdown-it-py~=0.5.0",

How are you installing and what version of markdown-it-py do you get?

[chrisjsewell]

I found your issue 😄 https://github.com/jupyterlab/benchmarks/pull/20/files#r473573584

[echarles]

Thx a lot @chrisjsewell Issue is now fixed

For background, those deps definition have been copied from this repo. There is #155 which could help to have stable version definition (so may be less pinning).

[chrisjsewell]

Yeh no worries that still on the TODO! but... if you do copy all the dep definitions then you also need to re-copy all of them when you upgrade 😉

Although really its not necessary to copy them all, you should just have in your setup.py the packages you directly depend on, rather than also their dependencies