-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get eval results from metadata #597
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #597 +/- ##
==========================================
+ Coverage 80.97% 80.98% +0.01%
==========================================
Files 30 30
Lines 2702 2714 +12
==========================================
+ Hits 2188 2198 +10
- Misses 514 516 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@agoose77 is there a way this can make it into this week’s release? |
Fixes #596
No idea how to elegantly pass the
SyntaxNode
all the way down to the role, and I’m not super interested in figuring that out, it’s your call how to implement that.