Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nest request_params within response params #811

Open
geemus opened this issue Jan 26, 2023 · 0 comments
Open

nest request_params within response params #811

geemus opened this issue Jan 26, 2023 · 0 comments
Labels

Comments

@geemus
Copy link
Contributor

geemus commented Jan 26, 2023

We have recently had a number of asks to include more and more request params into the response to facilitate logging, error handling, etc. Although we did this on a one-off way at the top level of the response, this is getting a bit messy in terms of mixing request/response params and also leaves us in a position of having to do this again any time request changes.

Instead, we should consider nesting all of the request_params as a subkey within response. This keeps the request/response parts separate and should allow this to be more future-proof. We could then update the reader methods to point to this nested value. That being said, we may need or want to double write to the old values in the hash for backwards compatibility.

Overall we should discuss more and make sure the plan is clear before proceeding, but I wanted to capture this here for now as a place to have that discussion. See also initial discussion in #809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant