Always set OpenSSL default paths #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if you set `SSL_CERT_FILE` to a directory with no certs,
this script would fail:
```ruby
require 'openssl'
require 'excon'
ENV['SSL_CERT_DIR'] = '/path/to/no/ssl/certs/'
excon = Excon.new('https://www.google.com')
excon.get
```
However, the same script with `Net::HTTP` works fine:
```ruby
require 'openssl'
require 'net/http'
ENV['SSL_CERT_DIR'] = '/path/to/no/ssl/certs/'
Net::HTTP.get(URI('https://www.google.com'))
```
To match the behavior of Net::HTTP, always call
`OpenSSL::X509::Store#set_default_paths` unless there is a store
specified.
stanhu
force-pushed
the
sh-set-default-paths
branch
from
dd185f9
to
d33be6c
Compare
|
@stanhu Do you need a release for this? |
|
@geemus Thanks for the quick merge. Sure, a release would be great. |
|
Sounds good. Should now be available in v0.90.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if you set
SSL_CERT_FILEto a directory with no certs,this script would fail:
However, the same script with
Net::HTTPworks fine:To match the behavior of Net::HTTP, always call
OpenSSL::X509::Store#set_default_pathsunless there is a storespecified.