Support ActiveSupport v7 #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/excon/excon/runs/4781841441 was failing: ``` Excon instrumentation basic notification - returns ["excon.request", "excon.response"] uninitialized constant ActiveSupport::IsolatedExecutionState (NameError) /home/runner/work/excon/excon/vendor/bundle/ruby/3.0.0/gems/activesupport-7.0.1/lib/active_support/notifications.rb:268:in `registry' /home/runner/work/excon/excon/vendor/bundle/ruby/3.0.0/gems/activesupport-7.0.1/lib/active_support/notifications.rb:263:in `instrumenter' /home/runner/work/excon/excon/vendor/bundle/ruby/3.0.0/gems/activesupport-7.0.1/lib/active_support/notifications.rb:206:in `instrument' ``` As rails/rails#43852 explains, we can just `require active_support` and this will auto-load the correct constants.
geemus
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/excon/excon/runs/4781841441 was failing:
As rails/rails#43852 explains, we can just
require active_supportand this will auto-load the correct constants.