Stop leaking sensitive header values in error messages #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The protection against invalid header values should not leak their content in the error message. Exceptions are commonly logged, sent to third-party error monitoring systems, or published in internal communication/messenger systems. A range of HTTP headers, like `Authorization`, `Api-Key`, or similar, contain sensitive information which should not be sent to such public destinations.
geemus
approved these changes
Oct 7, 2021
|
Released in v0.87.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The protection against invalid header values should not leak their
content in the error message. Exceptions are commonly logged, sent to
third-party error monitoring systems, or published in internal
communication/messenger systems. A range of HTTP headers, like
Authorization,Api-Key, or similar, contain sensitive informationwhich should not be sent to such public destinations.
Thank you for excon, a great library!
The protection against invalid header values is helpful, but we accidentally leaked an API token today (exception -> Bugsnag -> Slack) which was passed from an
ENV["API_TOKEN"]environment variable.