Prevent test suite lockups on test server failure #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses two issues: 1) When the test server fails for whatever reason, the test suite gets stuck in infinite loop reading stderr output. This can be simply prevented, because when the `gets` reads from closed pipe, it returns `nil`. 2) When the test server fails during startup, there is no way to know why. Therefore the server messages are collected and reported in case the stderr pipe is unexpectedly closed.
|
Please note that I have tried also more concise approach such as: $ git diff
diff --git a/lib/excon/test/plugin/server/puma.rb b/lib/excon/test/plugin/server/puma.rb
index d87a8af..b8e1a27 100644
--- a/lib/excon/test/plugin/server/puma.rb
+++ b/lib/excon/test/plugin/server/puma.rb
@@ -5,9 +5,10 @@ module Excon
module Puma
def start(app_str = app, bind_uri = bind)
open_process('puma', '-b', bind_uri.to_s, app_str)
- line = ''
- until line =~ /Use Ctrl-C to stop/
- line = read.gets
+ process_stderr = ""
+ until (line = read.gets) =~ /Use Ctrl-C to stop/
+ raise process_stderr if line.nil?
+ process_stderr << line
fatal_time = elapsed_time > timeout
raise 'puma server has taken too long to start' if fatal_time
endBut it was getting stuck for some strange reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses two issues:
When the test server fails for whatever reason, the test suite gets stuck in infinite loop reading stderr output. This can be simply prevented, because when the
getsreads from closed pipe, it returnsnil.When the test server fails during startup, there is no way to know why. Therefore the server messages are collected and reported in case the stderr pipe is unexpectedly closed.
Original behavior:
where the process infinitely loops here:
excon/tests/test_helper.rb
Lines 247 to 251 in b64de99
New behavior: