[bugfix] Overwrite socket data if already initialized #754
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out I introduced a bug in #742 馃檲
We're reusing the socket in one of our middlewares and noticed that the new
datum
passed in the request wasn't being written to the existingsocket
s datum. This line used to besocket.data = datum
and currently with justsocket(datum)
, it only uses thedatum
when initializing the socket, which breaks the previous behaviour of overwriting on an existing socket.This patch should fix that, while also keeping the desired behaviour from #742