Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Overwrite socket data if already initialized #754

Merged
merged 1 commit into from Jul 16, 2021

Conversation

jjiang-stripe
Copy link
Contributor

Turns out I introduced a bug in #742 馃檲

We're reusing the socket in one of our middlewares and noticed that the new datum passed in the request wasn't being written to the existing sockets datum. This line used to be socket.data = datum and currently with just socket(datum), it only uses the datum when initializing the socket, which breaks the previous behaviour of overwriting on an existing socket.

This patch should fix that, while also keeping the desired behaviour from #742

@jjiang-stripe jjiang-stripe changed the title Overwrite socket data if already initialized [bugfix] Overwrite socket data if already initialized Jul 15, 2021
Copy link
Contributor

@geemus geemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed explanation and fix, glad we were able to catch it.

@geemus geemus merged commit 7aa10f8 into excon:master Jul 16, 2021
@geemus
Copy link
Contributor

geemus commented Jul 16, 2021

Released in v0.85.0.

@jjiang-stripe jjiang-stripe deleted the jjiang/fix-socket branch July 16, 2021 16:28
@param-stripe
Copy link

@geemus Thank you for the quick release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants