Make Host header be always the first in requests #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RFC 7230 5.4 tells that Host SHOULD be the first header sent. Some servers will refuse the request or redirect it indefinitely if the total HTTP content before the Host header is too large.
|
Thanks for the detailed report. Looks good. Testing is trickier here, I think it might require a custom server to check things. Did you have any particular ideas/thoughts? |
|
Hey sorry for the delay. Let me know if this seems good to you! |
|
Good catch, I forgot we already had that (it's been a while since I needed to dig deeper). |
geemus
requested changes
Oct 9, 2020
geemus
approved these changes
Oct 16, 2020
|
@andrepiske Thanks! Released as part of 0.77.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I observed that some servers (Cloudflare, for instance) will fail the request or will respond with redirects to the same URL if the Host header comes too late in the request.
I think this actually make sense from a security perspective, as having Host late in the request would mean a server with virtual hosts would have to buffer everything before the Host header before deciding where the request will land and whether the virtual host is even valid.
RFC 7230 section 5.4 supports this, stating that:
I propose here this changes that always lifts the Host header to be the first one sent. By looking at the previous lines, the
ifcondition shouldn't alter semantics as I don't see howdatum[:headers]['Host']could benil.What do you think? Happy to discuss solutions.
Would be also nice if someone could point me into which file I could add tests/specs :)