Excon::Socket.readline to use buffered reads #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Excon::Socket.readline` currently reads 1 byte at a time, by performing one syscall for each byte (through `::Socket::read_nonblock`). This change proposes to use the private `Excon::Socket.read_nonblock` primitive instead, to benefit from the read buffer. Tests & specs seem to run fine with this change.
|
Sorry for the delay, I was just a bit anxious as it feels like a bigger/more risky change. I think it should be fine though, as you suggest. Thanks for noticing this, it is nice to remove some of the non-block error handling duplication as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excon::Socket.readlinecurrently reads 1 byte at a time,by performing one syscall for each byte (through
::Socket::read_nonblock).This change proposes to use the private
Excon::Socket.read_nonblockprimitiveinstead, to benefit from the read buffer.
Tests & specs seem to run fine with this change.