Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 0.74.0, #718 was shipped, which introduced a dependency on
IPAddr
.This dependency has been transitively loaded by
openssl
since 2.2.0, released May 13, 2020, whichexcon
always loads. This means that Ruby installations using a version ofopenssl
from before May 13, 2020 can be missing loadingipaddr
.This PR adds that explicitly dependency to the relevant file:
lib/excon/connection.rb
.One thing I'm still not sure is why travis-ci is not failing for Ruby 2.3, given I can reliably reproduce it as follows:
Steps to reproduce
Then inside the container:
I'm seeing the following error: