Add ip-address handling to no_proxy-envvar #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geemus
approved these changes
Jun 9, 2020
|
Fix now released as part of 0.74.0. |
This was referenced Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did add handling for host IP-addresses. This should also give the ability to specify network-addreses like
10.0.0.0/8or[fc00::/7]in theno_proxyvariable.However, they will only be evaluated correctly if the requested URI also includes the IP-address.
Added an IPv4 and IPv6 address to the
no_proxyvariable in the tests, so they will fail, if this breaks again.Maybe additional test-cases are needed regarding the no_proxy handling like
Fixes #716