Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excon.stub with :url should parse query to hash #382

Open
danp opened this issue Apr 29, 2014 · 2 comments
Open

Excon.stub with :url should parse query to hash #382

danp opened this issue Apr 29, 2014 · 2 comments
Labels
Milestone

Comments

@danp
Copy link
Contributor

danp commented Apr 29, 2014

Related to #381 I noticed if a query is parsed out of a :url attribute passed to Excon.stub it's not being converted to a hash as one might expect.

@geemus
Copy link
Contributor

geemus commented May 1, 2014

Point taken. I wouldn't expect it to be converted for real requests (it seems inefficient to turn it to a hash and back to a string, if nothing else). But stubs might not match/work without this for mock stuff. Are you up for taking a stab at this or should I take it? Thanks!

@geemus geemus added this to the 1.0.0 milestone Aug 1, 2014
@stale
Copy link

stale bot commented Jul 30, 2018

This issue has been automatically marked stale due to inactivity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 30, 2018
@geemus geemus added pinned and removed wontfix labels Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants