Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host header includes port #368

Closed
mdemare opened this issue Feb 14, 2014 · 5 comments
Closed

Host header includes port #368

mdemare opened this issue Feb 14, 2014 · 5 comments

Comments

@mdemare
Copy link

mdemare commented Feb 14, 2014

Excon sends a port number with the Host header. This confuses some hosts, e.g.

curl -v 'http://urbact.eu/en/projects/innovation-creativity/eunivercities/our-project/' -H 'Host: urbact.eu:80' -o /dev/null (404)

vs.

curl -v 'http://urbact.eu/en/projects/innovation-creativity/eunivercities/our-project/' -H 'Host: urbact.eu' -o /dev/null (200)

@mdemare
Copy link
Author

mdemare commented Feb 14, 2014

Oh, there is a setting for that: Excon.new("http://urbact.eu", omit_default_port: true)

@geemus
Copy link
Contributor

geemus commented Feb 14, 2014

@mdemare yeah, for now using the option is probably your best bet. I think we may eventually just make that the default (but there are historical things that will make this a breaking change, so we haven't gotten to it quite yet). Sorry for the difficulty/confusion! Definitely have this on the radar for upcoming work: #357

@geemus geemus closed this as completed Feb 14, 2014
@mikehale
Copy link
Contributor

+1 for this issue, I just ran into a url that this was broken for: http://www.dynstatus.com/dynect-dns/feed

@geemus
Copy link
Contributor

geemus commented Mar 31, 2014

Yeah... Now tracked here: #357

@mloughran
Copy link

Update: now tracked in #448

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants