Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

response parser as middleware, possibly counterintuitive? #325

Open
geemus opened this issue Nov 13, 2013 · 2 comments
Open

response parser as middleware, possibly counterintuitive? #325

geemus opened this issue Nov 13, 2013 · 2 comments
Labels
pinned
Milestone
1.0.0

Comments

@geemus
Copy link
Contributor

geemus commented Nov 13, 2013

It was brought up that the ResponseParser usage is not intuitive. ie there was an expectation that the first middleware in the response stack would receive the response (not an empty thing that THEN gets filled in by ResponseParser). Consolidating might well make this a lot easier to reason about and use.

see also: vcr/vcr#356 (comment)
@geemus geemus mentioned this issue Nov 13, 2013
Merged
@stale
Copy link

stale bot commented Jul 30, 2018

This issue has been automatically marked stale due to inactivity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 30, 2018
@geemus
Copy link
Contributor Author

geemus commented Jul 30, 2018

Pinning as it does seem worth thinking about more.

@stale stale bot removed the wontfix label Jul 30, 2018
@geemus geemus added the pinned label Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pinned
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@geemus