Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace shindo #311

Closed
geemus opened this issue Oct 31, 2013 · 9 comments
Closed

replace shindo #311

geemus opened this issue Oct 31, 2013 · 9 comments
Milestone

Comments

@geemus
Copy link
Contributor

geemus commented Oct 31, 2013

shindo is weird and a barrier to contribution/updates. Seems like it might be good to migrate. These days I'm somewhat leaning toward rspec with assertions (not #should).

@nextmat
Copy link
Contributor

nextmat commented Nov 19, 2013

👍 I think this would be a good move.

@nextmat
Copy link
Contributor

nextmat commented Nov 19, 2013

Also I'd be up for tackling some of this but if so I'd like to work in chunks as I think the burden of tracking along w/ other changes would lead to an unpleasant monster-merge. What do you think?

@geemus
Copy link
Contributor Author

geemus commented Nov 20, 2013

Yeah. Doing it in chunks seems most tenable, especially in terms of other movement. That said, ideally we wouldn't have to support both suites for an extended period, as that has it's own nastiness.

@nextmat
Copy link
Contributor

nextmat commented Nov 20, 2013

Agreed, I'm with you on that.

@geemus geemus changed the title minitest? replace shindo Jul 29, 2014
@bjeanes
Copy link
Contributor

bjeanes commented Aug 6, 2014

@geemus does your renaming of this issue away from minitest? indicate a change in preference or just a general restating of goals? If I or @kahlouie were to start working on an alternate test suite, do you have a strong preference for testing library used?

@geemus
Copy link
Contributor Author

geemus commented Aug 6, 2014

@bjeanes a fine question. It is somewhat of both I think (change of preference and restatement). I'm leaning somewhat toward rspec due to it having a more active (and welcoming) community around it. I like the minimality of minitest, but not method-named-tests nor the relatively closed/unwelcoming community I've found there. Happy to discuss further though.

@bjeanes
Copy link
Contributor

bjeanes commented Aug 6, 2014

Sounds good to me. I've been using minitest in new projects of mine for simplicity reasons, but RSpec is a fine choice given the mentioned constraints.

@geemus
Copy link
Contributor Author

geemus commented Aug 6, 2014

@bjeanes yeah. I definitely know of pros/cons in both columns, but leaning toward rspec at least slightly at present due to more active development/community.

@geemus
Copy link
Contributor Author

geemus commented Jan 4, 2017

Close in favor of #575

@geemus geemus closed this as completed Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants