Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Idea #4

Closed
rockwellll opened this issue Apr 21, 2021 · 0 comments
Closed

Feature Idea #4

rockwellll opened this issue Apr 21, 2021 · 0 comments

Comments

@rockwellll
Copy link
Contributor

I think it would be better if we import the packages in the index.js file.

I have just installed the package and spent about an hour asking why the styles werent working, so after looking at this it turned out you had to require the css files manually.

So, i was thinking wouldn't it be better if we just do this

import { Controller } from 'stimulus'
import SlimSelect from 'slim-select'

require('slim-select/dist/slimselect.css')
require('slim-select/dist/slimselect.min.css')

that we require the files in the packages, so that the user(developer)doesn't worry about this, or spend an hour googling why it doesn't work, let me know if you like it so i can work a PR to address this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant