Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected "apply" tag (expecting closing tag for the "block" tag defined near line 2). #231

Open
perk11 opened this issue Jul 23, 2019 · 3 comments

Comments

@perk11
Copy link

perk11 commented Jul 23, 2019

I am getting

Unexpected "apply" tag (expecting closing tag for the "block" tag defined near line 2).

after installing the bundle with
php composer.phar require excelwebzone/recaptcha-bundle
having Twig 2.5.0/Symfony v3.4.15
Looks like 4dadc41 was supposed to fix this, but it still happens

@perk11
Copy link
Author

perk11 commented Jul 23, 2019

Version 1.5.13 works fine, so it would be good to tag it as the last version that works with previous versions of twig, because right now 1.5.14 is marked as supporting older Twig versions, while that's not the case.

@dxops
Copy link

dxops commented Aug 13, 2019

That is SemVer violation and a BC break. Would be great to get 1.16.0 instead of 1.5.14 and 1.5.15.

You will get 1.5.14 silently and will get errors. You will not receive 1.5.15 fix if your Twig version is 1.38.*(<1.40, <2.9), so that will not stop errors, the only one way is to downgrade the package to 1.5.13.

Would be nice to get 1.5.16 with f526d30 reverted.

What a bummer!

@chrisaligent
Copy link

Thanks for posting this, was just wondering why our application was throwing errors after applying a minor security patch release for the framework we're using.
Looks like it upgraded this Bundle to 1.5.14, which as @dxops noted shouldn't have been a breaking change:
image

We're stuck on Twig 1.X (currently v1.38.4) until a major framework upgrade is applied, so I'll lock the Recaptcha Bundle to 1.5.13 until then to resolve the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants