Lefthook for Dart

[igorkamyshev]

Hello! I want to use lefthook with Dart. I can make a PR for that, but I have a couple of questions.

Do you publish all packages manaully? Who will publish new versions to pub (Dart package registry)?

P.S. Thanks for lib, it is really great! 😻

[igorkamyshev]

What do you think in general about this idea?

[Arkweid]

Hello @igorkamyshev, that's a great idea! You can do i simple wrapper and maintain it. For example like this wrapper for pip:
https://github.com/life4/lefthook
We can add your wrapper in our documentation. Is it possible for you?

Do you publish all packages manaully?

Yep, I publish it with goreleaser + npm publish + rake.

[igorkamyshev]

Nice, thanks. I will do it, and send notification for you.

[igorkamyshev]

Hello! I wrote Dart-wrapper for Lefthook. Can you add that link to official repo?

https://github.com/drt-pkgz/lefthook

Also, I have one question.

In repare-commit-msg hook I found next text:

#!/bin/sh

if [ "{$LEFTHOOK}" = "0" ]; then
	exit 0
fi

# lefthook_version: d41d8cd98f00b204e9800998ecf8427e

cmd="lefthook install"

if lefthook >/dev/null 2>&1
then
	exec $cmd
elif bundle exec lefthook >/dev/null 2>&1
then
	bundle exec $cmd
elif npx lefthook >/dev/null 2>&1
then
	npx $cmd
fi

cmd="lefthook run prepare-commit-msg $@"

if lefthook >/dev/null 2>&1
then
  exec $cmd
elif bundle exec lefthook >/dev/null 2>&1
then
  bundle exec $cmd
elif npx lefthook >/dev/null 2>&1
then
  npx $cmd
else
  echo "Can't find lefthook in PATH"
fi

I guess, it may be confusing, if folk uses this tool from Dart, but Lefthook try to use npx, ruby-stuff, etc. Can you provide API to set this commands implicitly by first install? I mean something like this:

lefthook install --install-command="pub global activate lefthook"

[Arkweid]

Yep, I can do that.
Right now I have semi-vacations days, so it took a while for this feature. Sorry about that.

[igorkamyshev]

It's okay, have a nice days-off.

Please, ping me, when you do this changes.

[Arkweid]

Yep, no problem.

[igorkamyshev]

Hi. What about this enhancement?

[Arkweid]

Sorry for so long, planned on following week.

[igorkamyshev]

Hello! Sorry for interruption. Do you plan make this enhancement? If you don't want to do this, it is okay, please just tell me about it 🤗 (because, this issue in my Things app and I can't just close any task without reason 😂)

[Arkweid]

@igorkamyshev I will! I just really have a very limited time :(
Or if you want to take this(it would be great) I can guide you through the code step by step. Like this:
#72 (comment)
#64 (comment)

[igorkamyshev]

@Arkweid yep. I am really bad in Go, but I want try 🤓 Please, provide instructions for me.

[Arkweid]

Ye @igorkamyshev ! Lets try this flow:

1. Add new config key, for example bin_path, like here:
   https://github.com/Arkweid/lefthook/blob/master/cmd/root.go#L16-L23
2. Add new available flag for install command lefthook install --bin-path=./node_modules/@arkweid/lefthook
   https://github.com/Arkweid/lefthook/blob/master/cmd/root.go#L59-L60
   You can find the reference in cobra repository for that part: https://github.com/spf13/cobra
   We using it for avoid CLI boilerplate.
3. Automatically add it into lefthook.yml config file when user provide bin_path flag. Template here:
   https://github.com/Arkweid/lefthook/blob/master/cmd/install.go#L73-L108
4. Now we have all required things to add a hooks with desired bin_path. Template for that here:
   https://github.com/Arkweid/lefthook/blob/master/cmd/add.go#L73-L84
5. Make the same changes for _windows.go files.
6. (optinal) If you feel a power - write the tests!
7. ...
8. Profit!

[charlie-wasp]

@igorkamyshev hi! Is this issue still relevant for you by any chance?

[skryukov]

I've moved the resulting feature request to a separate issue so that we can close this.