Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Upstream PR - Allow ts3server URLs as custom links. #750

Closed
maxtsero opened this issue Jan 17, 2021 · 6 comments
Closed

Tracking Upstream PR - Allow ts3server URLs as custom links. #750

maxtsero opened this issue Jan 17, 2021 · 6 comments

Comments

@maxtsero
Copy link

maxtsero commented Jan 17, 2021

  • Problem: It's currently not possible to add a link directly to a TeamSpeak3 server as the Laravel Validator doesn't support the ts3server URI scheme.
  • Expected: The URI scheme is valid and should, therefore work!
  • Version Info: PHP 7.3, SeAT Current Stable, Ubuntu 20.04.
  • Other Info: An Upstream PR has been opened already. Once this is merged we just need to bump the laravel/framework version appropriately.
@warlof
Copy link
Member

warlof commented Jan 17, 2021

Wrong repository. Please open it on third party seat-connector.

Also, SeAT is using Laravel LTS, which is currently 6.x.

@warlof warlof closed this as completed Jan 17, 2021
@warlof warlof added third-party Issues which may be fixed by a third-party package wontfix Issues which will not be addressed by core labels Jan 17, 2021
@xcrf
Copy link

xcrf commented Jan 18, 2021

@warlof I think this is tracking the customlink feature in the web package for the sidebar menu.

@warlof warlof reopened this Jan 18, 2021
@warlof
Copy link
Member

warlof commented Jan 18, 2021

Oh, sorry - I miss understand the case.
However, SeAT is still targeting LTS version

@warlof warlof removed third-party Issues which may be fixed by a third-party package wontfix Issues which will not be addressed by core labels Jan 18, 2021
@maxtsero
Copy link
Author

Probably right to close this @warlof - it's logged now and will show up if someone has the issue. If Laravel accept the PR it will eventually trickle down and work in SeAT :-)

@warlof
Copy link
Member

warlof commented Jan 18, 2021

All right, closing it then.

@warlof warlof closed this as completed Jan 18, 2021
@homotechsual
Copy link

Thanks :-) Laravel merged the fix, so eventually it'll make it's way through to SeAT, until then you can either edit the Laravel Framework package (or patch it) or use https redirection to link to your TS server by linking as https://invite.teamspeak.com/ts.yourserver.uk/?password=yourserverpassword

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants