don't crash on PyPy 7.0.0 #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hey are implemented natively instead of being in pure-python. Fix commit fixes the code in the sense that at least doesn't crash on PyPy, but it still suffers of issue546, as python3.6 does
Codecov Report
@@ Coverage Diff @@
## master #547 +/- ##
========================================
Coverage ? 44%
========================================
Files ? 87
Lines ? 11832
Branches ? 1777
========================================
Hits ? 5278
Misses ? 6158
Partials ? 396
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
any chance this can be merged? |
|
we really need this for latest pypy support. |
temoto
reviewed
Oct 21, 2020
temoto
reviewed
Oct 21, 2020
jstasiak
approved these changes
Oct 21, 2020
bors bot
added a commit
to duckinator/parts.horse
that referenced
this pull request
Oct 24, 2020
68: Update eventlet to 0.29.1 r=duckinator a=pyup-bot This PR updates [eventlet](https://pypi.org/project/eventlet) from **0.28.0** to **0.29.1**. <details> <summary>Changelog</summary> ### 0.29.1 ``` ====== patcher: [py27] recursion error in pytest/python2.7 installing register_at_fork eventlet/eventlet#660 patcher: monkey_patch(builtins=True) failed on py3 because `file` class is gone eventlet/eventlet#541 don't crash on PyPy 7.0.0 eventlet/eventlet#547 Only install monotonic on python2 eventlet/eventlet#583 ``` ### 0.29.0 ``` ====== * ssl: context wrapped listener fails accept() eventlet/eventlet#651 ``` ### 0.28.1 ``` ====== * Sorry, Eventlet was broken on Windows for versions 0.27-0.28 patcher: no os.register_at_fork on Windows (654) * Clean up TypeError in __del__ ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/eventlet - Changelog: https://pyup.io/changelogs/eventlet/ - Homepage: http://eventlet.net </details> Co-authored-by: pyup-bot <github-bot@pyup.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyPy 7.0.0 uses 'py3-style' rlocks, i.e. they are implemented natively instead of being in pure-python. Fix commit fixes the code in the sense that at least doesn't crash on PyPy, but it still suffers of issue546, as python3.6 does