Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patcher: no os.register_at_fork on Windows #654

Merged
merged 1 commit into from Oct 19, 2020
Merged

patcher: no os.register_at_fork on Windows #654

merged 1 commit into from Oct 19, 2020

Conversation

temoto
Copy link
Member

@temoto temoto commented Oct 17, 2020

#644

Eventlet 0.27.0 and 0.28.0 were incompatible with Windows (and other non-Unix) platforms

@temoto
patcher: no os.register_at_fork on Windows
95a0e0d 
#644

Eventlet 0.27.0 and 0.28.0 were incompatible with Windows (and other non-Unix) platforms
@temoto temoto requested a review from tipabu October 17, 2020 23:07
tipabu
tipabu approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@tipabu tipabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks entirely reasonable, and I remember thinking at the time that I should maybe do a hasattr check. Sorry for the breakage.

@tipabu tipabu merged commit f227ef6 into master Oct 19, 2020
@tipabu tipabu deleted the i644 branch October 19, 2020 17:09
@lobsterkatie lobsterkatie mentioned this pull request Oct 20, 2020
Closed
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tipabu tipabu tipabu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@temoto @tipabu