Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eventlet monkey patched SSL context does not observe environment PYTHONHTTPSVERIFY=0 or PEP 493 settings #484

Closed
Tehsmash opened this issue Apr 30, 2018 · 1 comment
Closed

Eventlet monkey patched SSL context does not observe environment PYTHONHTTPSVERIFY=0 or PEP 493 settings #484

Tehsmash opened this issue Apr 30, 2018 · 1 comment

Comments

@Tehsmash
Copy link

Eventlet monkey patches the default SSL context and as a result circumvents the logic added to python's ssl.py to change the default SSL verification behaviour here https://github.com/python/cpython/blob/2.7/Lib/ssl.py#L508-L518
Tehsmash added a commit to Tehsmash/eventlet that referenced this issue Apr 30, 2018
@Tehsmash
Ensure eventlet SSL HTTPs contexts allow HTTP verify disabled
b8699f3 
Python SSL supports a couple of different ways to disable HTTPS
verification, either via an environment variable or via methods defined
in PEP 493. To ensure these work we must call the original
_create_default_https_context function to ensure we are calling the
right default https context (verified or unverified) function according
set by the https context factory.

Fixes eventlet#484
@Tehsmash Tehsmash mentioned this issue Apr 30, 2018
Open
@temoto
Copy link
Member

temoto commented Apr 30, 2018

Thank you. Let's continue in pull #485 it seems to contain more value.

For future: there is no bureaucracy on creating issue and pull request here. Any way (issue, email, messengers, call) to submit idea is great and enough. Any way to transport a patch is great.

@temoto temoto closed this as completed Apr 30, 2018
temoto pushed a commit that referenced this issue Aug 19, 2020
@Tehsmash @temoto
Ensure eventlet SSL HTTPs contexts allow HTTP verify disabled
9909504 
Python SSL supports a couple of different ways to disable HTTPS
verification, either via an environment variable or via methods defined
in PEP 493. To ensure these work we must call the original
_create_default_https_context function to ensure we are calling the
right default https context (verified or unverified) function according
set by the https context factory.

Fixes #484
temoto pushed a commit that referenced this issue Oct 19, 2020
@Tehsmash @temoto
Ensure eventlet SSL HTTPs contexts allow HTTP verify disabled
9d7e5dc 
Python SSL supports a couple of different ways to disable HTTPS
verification, either via an environment variable or via methods defined
in PEP 493. To ensure these work we must call the original
_create_default_https_context function to ensure we are calling the
right default https context (verified or unverified) function according
set by the https context factory.

Fixes #484
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@temoto @Tehsmash