Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Loongarch LE architecture #2373

Merged
merged 6 commits into from Aug 2, 2022
Merged

Support Loongarch LE architecture #2373

merged 6 commits into from Aug 2, 2022

Conversation

beyond-1234
Copy link
Contributor

This PR adds support for Loongarch 64-bit LE Linux.

Please be informed:

  • For now, only Go@1.18.2 and newer suppoort Loongarch.
  • The version of golang.org/x/sys package must be above v0.0.0-20220624 . Details in this commit

@@ -0,0 +1,17 @@
{
"name": "esbuild-linux-loong64",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this package name doesn't work because it's already in use, and already has content published to it: https://www.npmjs.com/package/esbuild-linux-loong64. I will have to come up with another package name instead.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

"esbuild-linux-loong64" sounds like a good name, Whether can contact npmjs/esbuild-linux-loong64 package ,
ask him to help deal with this package

cheers~

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this package name doesn't work because it's already in use, and already has content published to it: https://www.npmjs.com/package/esbuild-linux-loong64. I will have to come up with another package name instead.

I have deleted this package.

Makefile Outdated
@@ -339,6 +340,9 @@ platform-linux-riscv64:
platform-linux-s390x:
@$(MAKE) --no-print-directory GOOS=linux GOARCH=s390x NPMDIR=npm/esbuild-linux-s390x platform-unixlike

platform-linux-loong64:
@$(MAKE) --no-print-directory GOOS=linux GOARCH=loong64 NPMDIR=npm/esbuild-linux-loong64 platform-unixlike
Copy link
Owner

@evanw evanw Jul 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • For now, only Go@1.18.2 and newer suppoort Loongarch.

When I try to run this command, I get this error:

go: unsupported GOOS/GOARCH pair linux/loong64

My go version:

go version go1.18.3 darwin/arm64

That implies that Go 1.18.2 and newer do not support this architecture. This makes sense because it's supposed to only be supported in Go 1.19 and up:

Go 1.19 adds support for the Loongson 64-bit architecture LoongArch on Linux (GOOS=linux, GOARCH=loong64).

See also: #1804

@evanw evanw merged commit d6cf390 into evanw:master Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants